abonerib
  • Joined on 2024-09-10
abonerib approved rarias/jungle#72 2024-09-12 09:40:11 +02:00
Update NixOS and other changes
abonerib commented on pull request rarias/jungle#72 2024-09-10 16:44:52 +02:00
Update NixOS and other changes

The documentation uses CR_Core, but it's probably case-insensitive: https://slurm.schedmd.com/cons_tres_share.html

abonerib commented on pull request rarias/jungle#72 2024-09-10 16:44:52 +02:00
Update NixOS and other changes

It would be nice to have broadcast a wall message some time before shutdown

abonerib commented on pull request rarias/jungle#72 2024-09-10 16:44:52 +02:00
Update NixOS and other changes

Perhaps it would be wiser to only do this on the machines where it's needed, since it could be a security concern?

abonerib commented on pull request rarias/jungle#72 2024-09-10 16:44:52 +02:00
Update NixOS and other changes

LGTM, I left a couple of comments, but it's mostly nitpicking. I didn't go through all the docker gitlab details, I assumed the configuration has been tested.