Update NixOS and other changes #72
Reference in New Issue
Block a user
Delete Branch "update-nixos"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Flake lock file updates: • Updated input 'agenix': 'github:ryantm/agenix/1381a759b205dff7a6818733118d02253340fd5e' (2024-04-02) → 'github:ryantm/agenix/de96bd907d5fbc3b14fc33ad37d1b9a3cb15edc6' (2024-07-09) • Updated input 'nixpkgs': 'github:NixOS/nixpkgs/6143fc5eeb9c4f00163267708e26191d1e918932' (2024-04-21) → 'github:NixOS/nixpkgs/693bc46d169f5af9c992095736e82c3488bf7dbb' (2024-07-14)LGTM, I left a couple of comments, but it's mostly nitpicking. I didn't go through all the docker gitlab details, I assumed the configuration has been tested.
@@ -0,0 +8,4 @@timerConfig = {OnCalendar = "*-08-02 11:00:00";RandomizedDelaySec = "10min";Unit = "systemd-poweroff.service";It would be nice to have broadcast a
wallmessage some time before shutdownI usually send some emails on the mailing list prior to that day. I think it would be good to send via wall too, feel free to send a patch or PR :-)
@@ -22,0 +16,4 @@# Allow ptracing (i.e. attach with GDB) any process of the same user, see:# https://www.kernel.org/doc/Documentation/security/Yama.txt"kernel.yama.ptrace_scope" = "0";Perhaps it would be wiser to only do this on the machines where it's needed, since it could be a security concern?
I think this would be needed in most machines, but it can be disabled in the storage nodes.
@@ -86,0 +90,4 @@# Ignore memory constraints and only use unused cores to share a node with# other jobs.SelectTypeParameters=CR_COREThe documentation uses
CR_Core, but it's probably case-insensitive: https://slurm.schedmd.com/cons_tres_share.htmlGood catch!
0a8db8bda6to4bd1648074Done. I added you as reviewer in the commit trailers too.
Pull request closed