rarias/jungle
rarias/jungle
1
0
Fork 0
Code Issues 28 Pull Requests Packages Projects Releases Wiki Activity

Add Koro node, vlopez user and eudy tunnings #60

Merged
arocanon merged 0 commits from development into master 2023-07-21 15:14:39 +02:00
Conversation 12 Commits - Files Changed -
arocanon commented 2023-07-21 11:29:56 +02:00 (Migrated from pm.bsc.es)
Copy Link
No description provided.
arocanon commented 2023-07-21 11:29:57 +02:00 (Migrated from pm.bsc.es)
Copy Link

assigned to @rarias

assigned to @rarias
rarias commented 2023-07-21 11:48:05 +02:00 (Migrated from pm.bsc.es)
Copy Link

Can you import them from ../../eudy/kernel/lttng.nix and ../../eudy/kernel/perf.nix, so they are kept in sync? Or do you plan them to be different?

Can you import them from `../../eudy/kernel/lttng.nix` and `../../eudy/kernel/perf.nix`, so they are kept in sync? Or do you plan them to be different?
rarias commented 2023-07-21 11:48:05 +02:00 (Migrated from pm.bsc.es)
Copy Link

Also, can we import these directly from eudy rather than duplicating them? They seem to be the same and remain so (not ./kernel.nix):

../eudy/cpufreq.nix
../eudy/users.nix
../eudy/slurm.nix

./users.nix

Also, if you import ../eudy/users.nix you already create your own account, so in ./users.nix we only need to add the vlopez user.

Also, can we import these directly from eudy rather than duplicating them? They seem to be the same and remain so (not `./kernel.nix`): ```nix ../eudy/cpufreq.nix ../eudy/users.nix ../eudy/slurm.nix ./users.nix ``` Also, if you import `../eudy/users.nix` you already create your own account, so in `./users.nix` we only need to add the vlopez user.
rarias commented 2023-07-21 11:48:05 +02:00 (Migrated from pm.bsc.es)
Copy Link

Thanks, looks good but I would like to reduce duplications if they are not strictly required.

Thanks, looks good but I would like to reduce duplications if they are not strictly required.
arocanon commented 2023-07-21 14:40:52 +02:00 (Migrated from pm.bsc.es)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/gitlab/rarias/jungle/-/merge_requests/16/diffs?diff_id=8889&start_sha=6afd7fa8a738393cced2798b1868130343b913e1#6dca1c0f91a6a46a77d1a942871c2ee7e72949ef_50_0)
arocanon commented 2023-07-21 14:40:52 +02:00 (Migrated from pm.bsc.es)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/gitlab/rarias/jungle/-/merge_requests/16/diffs?diff_id=8889&start_sha=6afd7fa8a738393cced2798b1868130343b913e1#4f2c49d7cdef0a396775f21212eddcc4e83adc7f_9_8)
arocanon commented 2023-07-21 14:40:52 +02:00 (Migrated from pm.bsc.es)
Copy Link

added 2 commits

Compare with previous version

added 2 commits <ul><li>66fb848b - Add koro node</li><li>79adbe76 - koro: Add vlopez user</li></ul> [Compare with previous version](/gitlab/rarias/jungle/-/merge_requests/16/diffs?diff_id=8889&start_sha=6afd7fa8a738393cced2798b1868130343b913e1)
arocanon commented 2023-07-21 14:43:03 +02:00 (Migrated from pm.bsc.es)
Copy Link

Sure! I have minimized the duplicated code. I have kept the kernel.nix aside to make sure that my work on eudy does not interfere with koro.

Sure! I have minimized the duplicated code. I have kept the `kernel.nix` aside to make sure that my work on eudy does not interfere with koro.
rarias commented 2023-07-21 15:09:51 +02:00 (Migrated from pm.bsc.es)
Copy Link

resolved all threads

resolved all threads
rarias commented 2023-07-21 15:09:56 +02:00 (Migrated from pm.bsc.es)
Copy Link

approved this merge request

approved this merge request
rarias commented 2023-07-21 15:10:17 +02:00 (Migrated from pm.bsc.es)
Copy Link

requested review from @rarias

requested review from @rarias
rarias commented 2023-07-21 15:10:28 +02:00 (Migrated from pm.bsc.es)
Copy Link

assigned to @arocanon and unassigned @rarias

assigned to @arocanon and unassigned @rarias
rarias (Migrated from pm.bsc.es) approved these changes 2024-05-29 10:53:28 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
rarias
Labels
Clear labels   
ceph

   
ci

   
config

   
hw

   
io

   
kernel

   
mpi

   
net

   
nix

   
ops
No Label
ceph
ci
config
hw
io
kernel
mpi
net
nix
ops
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: rarias/jungle#60
No description provided.
Delete Branch "development"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?