rarias/jungle
rarias/jungle
2
0
Fork 2
Code Issues 53 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Add missing which in nodes checkPhase #206

Merged
abonerib merged 1 commits from abonerib/jungle:fix/nodes-check-which into master 2025-10-24 11:02:07 +02:00
Conversation 1 Commits 1 Files Changed 1 +2 -1
abonerib commented 2025-10-23 14:44:02 +02:00
Collaborator
Copy Link

When enabling checks in nodes, the build log gets polluted with warnings.

In weasel: nix log /nix/store/1zxh6izdw23m9430wla915k8nmv03xzs-nodes-master.drv (weasel:3001/build/1389/log)

          nodes = prev.nodes.overrideAttrs (old: {
            doCheck = true;
            inherit requiredSystemFeatures = [ "sys-devices" ];
          });

make[2]: Entering directory '/build/zfjxsb3wzcjbjgb2gdj8nplf5lk05v1f-source/tests'
make  blocking.test commutative.test deadline.test discrete-deps.test discrete-deps-early-release.test discrete-dep>
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
make[3]: Entering directory '/build/zfjxsb3wzcjbjgb2gdj8nplf5lk05v1f-source/tests'
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
  CXX      correctness/blocking/blocking_test-blocking.o
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
  CXXLD    blocking.test
clang++: warning: argument unused during compilation: '-Wa,--compress-debug-sections' [-Wunused-command-line-argume>
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
/nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found
When enabling checks in nodes, the build log gets polluted with warnings. In weasel: `nix log /nix/store/1zxh6izdw23m9430wla915k8nmv03xzs-nodes-master.drv` (weasel:3001/build/1389/log) ```nix nodes = prev.nodes.overrideAttrs (old: { doCheck = true; inherit requiredSystemFeatures = [ "sys-devices" ]; }); ``` ``` make[2]: Entering directory '/build/zfjxsb3wzcjbjgb2gdj8nplf5lk05v1f-source/tests' make blocking.test commutative.test deadline.test discrete-deps.test discrete-deps-early-release.test discrete-dep> /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found make[3]: Entering directory '/build/zfjxsb3wzcjbjgb2gdj8nplf5lk05v1f-source/tests' /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found CXX correctness/blocking/blocking_test-blocking.o /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found CXXLD blocking.test clang++: warning: argument unused during compilation: '-Wa,--compress-debug-sections' [-Wunused-command-line-argume> /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found /nix/store/ih68ar79msmj0496pgld4r3vqfr7bbin-bash-5.2p37/bin/bash: line 1: which: command not found ```
abonerib added 1 commit 2025-10-23 14:44:03 +02:00
Fix missing which in nodes checkPhase
All checks were successful
CI / build:cross (pull_request) Successful in 6s
Details
CI / build:all (pull_request) Successful in 16s
Details
eeac26ccdb 
The check still works, but it pollutes the logs with errors
abonerib force-pushed fix/nodes-check-which from eeac26ccdb to 722bf42cc5 2025-10-23 14:45:13 +02:00 Compare
abonerib changed title from Fix missing which in nodes checkPhase to Add missing which in nodes checkPhase 2025-10-23 14:45:21 +02:00
rarias requested review from rarias 2025-10-23 14:47:42 +02:00
rarias approved these changes 2025-10-23 14:47:46 +02:00
abonerib force-pushed fix/nodes-check-which from 722bf42cc5 to 14d1a9fc2b 2025-10-23 15:18:23 +02:00 Compare
abonerib force-pushed fix/nodes-check-which from 14d1a9fc2b to ab86243a07 2025-10-23 15:59:29 +02:00 Compare
abonerib merged commit ab86243a07 into master 2025-10-24 11:02:07 +02:00
abonerib deleted branch fix/nodes-check-which 2025-10-24 11:02:07 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
rarias
Labels
Clear labels
bug
ceph
ci
config
hw
io
kernel
mpi
net
nix
ops
repair
slurm
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
abonerib arocanon varcila rarias
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rarias/jungle#206
No description provided.
Delete Branch "abonerib/jungle:fix/nodes-check-which"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?