Use nixpkgs from flake.lock and support attrs when importing bscpkgs #2

abonerib · 2025-06-16T12:04:04+02:00

abonerib commented

2025-06-16 12:04:04 +02:00

This makes nix-build and friends use the current flake lock instead of
the outdated pinned version we had in ./nixpkgs.nix

With this, nix-build -A ovni and nix build .#ovni should produce the
same result.

This will fail if the flake nixpkgs input does not come from NixOS/nixpkgs.
We could use edolstra/flake-compat instead, but it's overkill imho.

Additionally, I made default.nix behave like nixpkgs, so that we can
import bscpkgs à la nixpkgs (Apply overlays and other options that nixpkgs
accepts):

let pkgs = import bscpkgs { inherit system; }; in <...>

This makes `nix-build` and friends use the current flake lock instead of the outdated pinned version we had in `./nixpkgs.nix` With this, `nix-build -A ovni` and `nix build .#ovni` should produce the same result. This will fail if the flake nixpkgs input does not come from NixOS/nixpkgs. We could use edolstra/flake-compat instead, but it's overkill imho. Additionally, I made default.nix behave like nixpkgs, so that we can import bscpkgs à la nixpkgs (Apply overlays and other options that nixpkgs accepts): ```nix let pkgs = import bscpkgs { inherit system; }; in <...> ```

abonerib added 1 commit 2025-06-16 12:04:05 +02:00

Use nixpkgs from flake.lock and support attrs when importing bscpkgs 78c6090168

This makes `nix-build` and friends use the current flake lock instead of
the outdated pinned version we had in `./nixpkgs.nix`

With this, `nix-build -A ovni` and `nix build .#ovni` should produce the
same result.

This will fail if the flake nixpkgs input does not come from NixOS/nixpkgs.
We could use edolstra/flake-compat instead, but it's overkill imho.

Additionally, I made default.nix behave like nixpkgs, so that we can
import bscpkgs à la nixpkgs (Apply overlays and other options that nixpkgs
accepts):

```nix
let pkgs = import bscpkgs { inherit system; }; in <...>
```

rarias commented

2025-06-16 12:18:01 +02:00

Nice!, thanks.

Reviewed-by: Rodrigo Arias Mallo rodrigo.arias@bsc.es

Nice!, thanks. Reviewed-by: Rodrigo Arias Mallo <rodrigo.arias@bsc.es>

rarias requested review from rarias 2025-06-16 12:18:10 +02:00

rarias approved these changes 2025-06-16 12:18:24 +02:00

rarias force-pushed feat/import-bscpkgs from 78c6090168 to 2aa9eff970

2025-06-16 12:26:42 +02:00

Compare

rarias commented

2025-06-16 12:32:11 +02:00