From 87e4b829c5ee86f89e65416688597395a10b20ad Mon Sep 17 00:00:00 2001 From: Rodrigo Arias Date: Mon, 22 Jul 2024 16:56:29 +0200 Subject: [PATCH] Switch the mark tracking for threads to active In the thread view, the values will still be visible when the thread goes to Warming or Cooling states, instead of being removed like when the thread enters the Paused state. The CPU view will continue to track the running thread (only in the Running state). --- cfg/thread/ovni/mark.cfg | 6 +++--- src/emu/ovni/mark.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cfg/thread/ovni/mark.cfg b/cfg/thread/ovni/mark.cfg index a7ccac7..26652da 100644 --- a/cfg/thread/ovni/mark.cfg +++ b/cfg/thread/ovni/mark.cfg @@ -4,9 +4,9 @@ ConfigFile.NumWindows: 1 ################################################################################ -< NEW DISPLAYING WINDOW Thread: Mark value of the RUNNING thread > +< NEW DISPLAYING WINDOW Thread: Mark value of the ACTIVE thread > ################################################################################ -window_name Thread: Mark value of the RUNNING thread +window_name Thread: Mark value of the ACTIVE thread window_type single window_id 1 window_position_x 100 @@ -38,4 +38,4 @@ window_labels_to_draw 1 window_selected_functions { 14, { {cpu, Active Thd}, {appl, Adding}, {task, Adding}, {thread, Last Evt Val}, {node, Adding}, {system, Adding}, {workload, Adding}, {from_obj, All}, {to_obj, All}, {tag_msg, All}, {size_msg, All}, {bw_msg, All}, {evt_type, =}, {evt_value, All} } } window_compose_functions { 9, { {compose_cpu, As Is}, {compose_appl, As Is}, {compose_task, As Is}, {compose_thread, As Is}, {compose_node, As Is}, {compose_system, As Is}, {compose_workload, As Is}, {topcompose1, As Is}, {topcompose2, As Is} } } window_filter_module evt_type 1 100 -window_filter_module evt_type_label 1 "Thread: Mark value of the RUNNING thread" +window_filter_module evt_type_label 1 "Thread: Mark value of the ACTIVE thread" diff --git a/src/emu/ovni/mark.c b/src/emu/ovni/mark.c index 69908be..a29561e 100644 --- a/src/emu/ovni/mark.c +++ b/src/emu/ovni/mark.c @@ -330,8 +330,8 @@ create_thread_chan(struct ovni_mark_emu *m, struct bay *bay, struct thread *th) for (type = m->types; type; type = type->hh.next) { long i = type->index; struct track *track = &t->track[i]; - /* For now only tracking to running thread is supported */ - if (track_init(track, bay, TRACK_TYPE_TH, TRACK_TH_RUN, + /* For now only tracking to active thread is supported */ + if (track_init(track, bay, TRACK_TYPE_TH, TRACK_TH_ACT, fmt, th->gindex, type->type) != 0) { err("track_init failed"); return -1;