Remove reg-names property from clint

This commit is contained in:
Rodrigo Arias 2024-07-12 12:38:34 +02:00
parent dc8a8c2ce9
commit 6604911264
2 changed files with 27 additions and 2 deletions

View File

@ -1584,3 +1584,29 @@ What I don't understand is why the MMIO region 0 is starting at 0x40000000 while
the UART port should be mapped in 0x40001000 as per the device tree. Maybe we the UART port should be mapped in 0x40001000 as per the device tree. Maybe we
could try with the generic configuration of OpenSBI and see if it can load the could try with the generic configuration of OpenSBI and see if it can load the
plic and the serial ports properly directly from the device tree. plic and the serial ports properly directly from the device tree.
Nice, with OpenSBI 1.5 I can see the console errors when trying the generic
configuration:
OpenSBI v1.5
____ _____ ____ _____
/ __ \ / ____| _ \_ _|
| | | |_ __ ___ _ __ | (___ | |_) || |
| | | | '_ \ / _ \ '_ \ \___ \| _ < | |
| |__| | |_) | __/ | | |____) | |_) || |_
\____/| .__/ \___|_| |_|_____/|____/_____|
| |
|_|
init_coldboot: timer init failed (error -3)
Seems to be failing in `sbi_timer_init()` with `cold_boot = true`.
And the -3 error seems to be:
#define SBI_ERR_INVALID_PARAM -3
I assume it is calling `fdt_timer_init()`.
Let's try removing the `reg-names` property, as it seems to cause it to enter a
different branch, but "control" is never matched there.

View File

@ -228,9 +228,8 @@
* property is described in * property is described in
* Documentation/devicetree/bindings/riscv/cpus.yaml * Documentation/devicetree/bindings/riscv/cpus.yaml
*/ */
timer@40002000 { clint: clint@40002000 {
reg = <0x0 0x40002000 0x0 0x000c0000>; reg = <0x0 0x40002000 0x0 0x000c0000>;
reg-names = "control";
interrupts-extended = <&HLIC0 3>, <&HLIC0 7>; interrupts-extended = <&HLIC0 3>, <&HLIC0 7>;
/*<&CPU0 0x3>, <&CPU0 0x7>,*/ /*<&CPU0 0x3>, <&CPU0 0x7>,*/
/*<&onic_pool 0x3>, <&onic_pool 0x7>,*/ /*<&onic_pool 0x3>, <&onic_pool 0x7>,*/