Enable custom sys-devices system feature #181

abonerib · 2025-09-30T15:41:29+02:00

abonerib commented

2025-09-30 15:41:29 +02:00

Allows running nos-v programs inside the sandbox

nosv = prev.nosv.overrideAttrs (old: {
    doCheck = true;
    requiredSystemFeatures = [ "sys-devices" ];
});

http://weasel:3001/eval/40

Allows running nos-v programs inside the sandbox ```nix nosv = prev.nosv.overrideAttrs (old: { doCheck = true; requiredSystemFeatures = [ "sys-devices" ]; }); ``` http://weasel:3001/eval/40

abonerib added 1 commit 2025-09-30 15:41:30 +02:00

Enable nosv system feature db6a3faa44

rarias commented

2025-10-01 12:53:13 +02:00

I remember that we had a similar problem in Nanos6 (and now potentially in NODES too). I suspect is the same paths in all cases. Would it make sense to generalize this for all and name it as in "access to /sys information about the CPU and node" instead?

abonerib force-pushed nosv-sys-feature from db6a3faa44 to 91fa59e397

2025-10-02 15:59:51 +02:00

Compare

abonerib changed target branch from old-master to master

2025-10-02 16:02:14 +02:00

abonerib commented

2025-10-02 16:47:22 +02:00

I remember that we had a similar problem in Nanos6 (and now potentially in NODES too). I suspect is the same paths in all cases. Would it make sense to generalize this for all and name it as in "access to /sys information about the CPU and node" instead?

I did try nodes and this is enough for it. Not sure for nanos6, I would have to check, but I would need to fix the nanos6 derivation to include the proper dependencies to run its tests.

Anyway, I don't see any issue with exposing the whole /sys

> I remember that we had a similar problem in Nanos6 (and now potentially in NODES too). I suspect is the same paths in all cases. Would it make sense to generalize this for all and name it as in "access to /sys information about the CPU and node" instead? I did try nodes and this is enough for it. Not sure for nanos6, I would have to check, but I would need to fix the nanos6 derivation to include the proper dependencies to run its tests. Anyway, I don't see any issue with exposing the whole `/sys`

rarias commented

2025-10-02 17:19:44 +02:00

I remember that we had a similar problem in Nanos6 (and now potentially in NODES too). I suspect is the same paths in all cases. Would it make sense to generalize this for all and name it as in "access to /sys information about the CPU and node" instead?

I did try nodes and this is enough for it.

Great!

Not sure for nanos6, I would have to check, but I would need to fix the nanos6 derivation to include the proper dependencies to run its tests.

Then I would leave adding potential fixes for Nanos6 for when we need it.

Anyway, I don't see any issue with exposing the whole /sys

I would prefer to only include what we need as we do now, and wait until we have a case to expand the set, as I cannot predict the consequences of opening the whole /sys.

Can we rename this to something more generic? Maybe we can just name it sys-devices?

> > I remember that we had a similar problem in Nanos6 (and now potentially in NODES too). I suspect is the same paths in all cases. Would it make sense to generalize this for all and name it as in "access to /sys information about the CPU and node" instead? > > I did try nodes and this is enough for it. Great! > Not sure for nanos6, I would have to check, but I would need to fix the nanos6 derivation to include the proper dependencies to run its tests. Then I would leave adding potential fixes for Nanos6 for when we need it. > Anyway, I don't see any issue with exposing the whole `/sys` I would prefer to only include what we need as we do now, and wait until we have a case to expand the set, as I cannot predict the consequences of opening the whole /sys. Can we rename this to something more generic? Maybe we can just name it `sys-devices`?

👍 1

abonerib force-pushed nosv-sys-feature from 91fa59e397 to a28eb9ac65

2025-10-02 17:43:43 +02:00

Compare

abonerib changed title from ~~Enable nosv system feature~~ to Enable custom sys-devices system feature

2025-10-02 17:44:40 +02:00

abonerib force-pushed nosv-sys-feature from a28eb9ac65 to 00456a86b7

2025-10-06 14:48:05 +02:00

Compare

abonerib force-pushed nosv-sys-feature from 00456a86b7 to 510d9046ce

2025-10-07 17:09:05 +02:00

Compare