GPI-2 broken on new rdma-core #7

New Issue

rarias · 2025-07-21T12:11:12+02:00

rarias commented

2025-07-21 12:11:12 +02:00

       > libtool: link: gcc -fPIC -std=gnu11 -Wall -o gaspi_logger gaspi_logger.o  -lm
       > GPI2.c: In function 'pgaspi_proc_init':
       > GPI2.c:294:20: warning: unused variable 'mbuf' [-Wunused-variable]
       >   294 |     struct utsname mbuf;
       >       |                    ^~~~
       > devices/ib/GPI2_IB.c: In function 'pgaspi_ib_dev_print_info':
       > devices/ib/GPI2_IB.c:96:7: error: implicit declaration of function 'ibv_read_sysfs_file' [-Wimplicit-function-declaration]
       >    96 |   if (ibv_read_sysfs_file
       >       |       ^~~~~~~~~~~~~~~~~~~
       > devices/ib/GPI2_IB.c: In function 'pgaspi_ib_dev_print_info':
       > devices/ib/GPI2_IB.c:96:7: error: implicit declaration of function 'ibv_read_sysfs_file' [-Wimplicit-function-declaration]
       >    96 |   if (ibv_read_sysfs_file
       >       |       ^~~~~~~~~~~~~~~~~~~
       > make[2]: *** [Makefile:1687: devices/ib/libGPI2_la-GPI2_IB.lo] Error 1
       > make[2]: *** [Makefile:1463: devices/ib/libGPI2_stats_la-GPI2_IB.lo] Error 1
       > make[2]: Leaving directory '/build/GPI-2-tagaspi-2021.11/src'
       > make[1]: *** [Makefile:501: all-recursive] Error 1
       > make[1]: Leaving directory '/build/GPI-2-tagaspi-2021.11'
       > make: *** [Makefile:398: all] Error 2
       For full logs, run:
         nix log /nix/store/f216asdaa3mmpcncg3k3ldfrmjh2v10d-GPI-2-tagaspi-2021.11.drv

Because:

60aa1cb57a/libibverbs/driver.h (L722)
60aa1cb57a/libibverbs/CMakeLists.txt (L11-L14)
60aa1cb57a/buildlib/publish_headers.cmake (L4-L5)

``` > libtool: link: gcc -fPIC -std=gnu11 -Wall -o gaspi_logger gaspi_logger.o -lm > GPI2.c: In function 'pgaspi_proc_init': > GPI2.c:294:20: warning: unused variable 'mbuf' [-Wunused-variable] > 294 | struct utsname mbuf; > | ^~~~ > devices/ib/GPI2_IB.c: In function 'pgaspi_ib_dev_print_info': > devices/ib/GPI2_IB.c:96:7: error: implicit declaration of function 'ibv_read_sysfs_file' [-Wimplicit-function-declaration] > 96 | if (ibv_read_sysfs_file > | ^~~~~~~~~~~~~~~~~~~ > devices/ib/GPI2_IB.c: In function 'pgaspi_ib_dev_print_info': > devices/ib/GPI2_IB.c:96:7: error: implicit declaration of function 'ibv_read_sysfs_file' [-Wimplicit-function-declaration] > 96 | if (ibv_read_sysfs_file > | ^~~~~~~~~~~~~~~~~~~ > make[2]: *** [Makefile:1687: devices/ib/libGPI2_la-GPI2_IB.lo] Error 1 > make[2]: *** [Makefile:1463: devices/ib/libGPI2_stats_la-GPI2_IB.lo] Error 1 > make[2]: Leaving directory '/build/GPI-2-tagaspi-2021.11/src' > make[1]: *** [Makefile:501: all-recursive] Error 1 > make[1]: Leaving directory '/build/GPI-2-tagaspi-2021.11' > make: *** [Makefile:398: all] Error 2 For full logs, run: nix log /nix/store/f216asdaa3mmpcncg3k3ldfrmjh2v10d-GPI-2-tagaspi-2021.11.drv ``` Because: https://github.com/linux-rdma/rdma-core/blob/60aa1cb57a5b4abe73ff4242bc75b7a81771d75a/libibverbs/driver.h#L722 https://github.com/linux-rdma/rdma-core/blob/60aa1cb57a5b4abe73ff4242bc75b7a81771d75a/libibverbs/CMakeLists.txt#L11-L14 https://github.com/linux-rdma/rdma-core/blob/60aa1cb57a5b4abe73ff4242bc75b7a81771d75a/buildlib/publish_headers.cmake#L4-L5

rarias commented

2025-09-12 13:21:26 +02:00

They made the drivers.h file private in 2017(!):

56dd87acd2

However, the symbol is still there and exported:

hut$ nm /nix/store/wbld1h3lv6dg5iscy7lx0mdr6kd6989j-rdma-core-all/lib/libibverbs.so | grep ibv_read_sysfs_file
0000000000018790 T ibv_read_sysfs_file
0000000000018700 t ibv_read_sysfs_file_at

We may be able to get it working by adding the definitions on GPI-2.

They made the drivers.h file private in 2017(!): https://github.com/linux-rdma/rdma-core/commit/56dd87acd29279c81adfcf95f9d4d14806a2b615 However, the symbol is still there and exported: ``` hut$ nm /nix/store/wbld1h3lv6dg5iscy7lx0mdr6kd6989j-rdma-core-all/lib/libibverbs.so | grep ibv_read_sysfs_file 0000000000018790 T ibv_read_sysfs_file 0000000000018700 t ibv_read_sysfs_file_at ``` We may be able to get it working by adding the definitions on GPI-2.

rarias referenced this issue from a commit

2025-09-12 13:41:12 +02:00

Fix GPI-2 and enable TAGASPI

rarias referenced this issue from a commit

2025-09-12 14:21:26 +02:00

Fix GPI-2 and enable TAGASPI

rarias closed this issue

2025-09-12 14:23:13 +02:00

This repo is archived. You cannot comment on issues.