From 2fc46b9ead28343c7c5af0fcce7f64aafd6af6d0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aleix=20Bon=C3=A9?= <aleix.boneribo@bsc.es>
Date: Fri, 29 Aug 2025 11:41:10 +0200
Subject: [PATCH] Clean up paraver derivations

---
 pkgs/paraver/default.nix | 58 +++++++++++++++++++++++-----------------
 pkgs/paraver/kernel.nix  | 41 +++++++++++++++++-----------
 2 files changed, 58 insertions(+), 41 deletions(-)

diff --git a/pkgs/paraver/default.nix b/pkgs/paraver/default.nix
index 32e9796..f5319aa 100644
--- a/pkgs/paraver/default.nix
+++ b/pkgs/paraver/default.nix
@@ -1,25 +1,28 @@
 {
-  stdenv
-, fetchFromGitHub
-, autoreconfHook
-, boost
-, libxml2
-, xml2
-, wxGTK32
-, autoconf
-, automake
-, paraverKernel
-, openssl
-, glibcLocales
-, wrapGAppsHook
+  stdenv,
+  fetchFromGitHub,
+  autoreconfHook,
+  boost,
+  libxml2,
+  xml2,
+  wxGTK32,
+  autoconf,
+  automake,
+  paraverKernel,
+  openssl,
+  glibcLocales,
+  wrapGAppsHook,
+
+  enableDebug ? false,
 }:
 
 let
   wx = wxGTK32;
-in
-stdenv.mkDerivation rec {
-  pname = "wxparaver";
   version = "4.12.0";
+in
+stdenv.mkDerivation {
+  pname = "wxparaver";
+  inherit version;
 
   src = fetchFromGitHub {
     owner = "bsc-performance-tools";
@@ -36,21 +39,26 @@ stdenv.mkDerivation rec {
     ./fix-boost-87.patch
   ];
 
-  hardeningDisable = [ "all" ];
-
   # Fix the PARAVER_HOME variable
   postPatch = ''
     sed -i 's@^PARAVER_HOME=.*$@PARAVER_HOME='$out'@g' docs/wxparaver
     sed -i '1aexport LOCALE_ARCHIVE="${glibcLocales}/lib/locale/locale-archive"' docs/wxparaver
   '';
 
-  dontStrip = true;
   enableParallelBuilding = true;
 
-  preConfigure = ''
-    export CFLAGS="-O3"
-    export CXXFLAGS="-O3"
-  '';
+  hardeningDisable = [ "all" ];
+
+  dontStrip = true;
+
+  env =
+    let
+      flags = if enableDebug then "-ggdb -Og" else "-O3";
+    in
+    {
+      CFLAGS = flags;
+      CXXFLAGS = flags;
+    };
 
   configureFlags = [
     "--with-boost=${boost}"
@@ -68,11 +76,11 @@ stdenv.mkDerivation rec {
 
   buildInputs = [
     boost
-    libxml2.dev
+    libxml2
     xml2
     wx
     paraverKernel
-    openssl.dev
+    openssl
   ];
 
   postInstall = ''
diff --git a/pkgs/paraver/kernel.nix b/pkgs/paraver/kernel.nix
index 588aa3d..5f71828 100644
--- a/pkgs/paraver/kernel.nix
+++ b/pkgs/paraver/kernel.nix
@@ -1,19 +1,24 @@
 {
-  stdenv
-, fetchFromGitHub
-, autoreconfHook
-, boost
-, libxml2
-, xml2
-, autoconf
-, automake
-, pkg-config
-, zlib
+  stdenv,
+  fetchFromGitHub,
+  autoreconfHook,
+  boost,
+  libxml2,
+  xml2,
+  autoconf,
+  automake,
+  pkg-config,
+  zlib,
+
+  enableDebug ? false,
 }:
 
-stdenv.mkDerivation rec {
-  pname = "paraver-kernel";
+let
   version = "4.12.0";
+in
+stdenv.mkDerivation {
+  pname = "paraver-kernel";
+  inherit version;
 
   src = fetchFromGitHub {
     owner = "bsc-performance-tools";
@@ -34,10 +39,14 @@ stdenv.mkDerivation rec {
 
   dontStrip = true;
 
-  preConfigure = ''
-    export CFLAGS="-O3 -DPARALLEL_ENABLED"
-    export CXXFLAGS="-O3 -DPARALLEL_ENABLED"
-  '';
+  env =
+    let
+      flags = "-DPARALLEL_ENABLED " + (if enableDebug then "-ggdb -Og" else "-O3");
+    in
+    {
+      CFLAGS = flags;
+      CXXFLAGS = flags;
+    };
 
   configureFlags = [
     "--with-boost=${boost}"